Bug 1337154: More information in the crash reports when mismatching DLL versions are present. r?gw280 draft
authorMilan Sreckovic <milan@mozilla.com>
Mon, 06 Feb 2017 17:29:25 -0500
changeset 479565 d548efbf6c09a9462acf79ae9a03cfc4596636d5
parent 479455 12c02bf624c48903b155428f7c8a419ba7a333a6
child 544723 c3f44a7db47e481af61edc055b519d6659dcd369
push id44294
push userbmo:milan@mozilla.com
push dateMon, 06 Feb 2017 22:29:53 +0000
reviewersgw280
bugs1337154
milestone54.0a1
Bug 1337154: More information in the crash reports when mismatching DLL versions are present. r?gw280 MozReview-Commit-ID: 7ygQzFVmBsq
widget/windows/GfxInfo.cpp
--- a/widget/windows/GfxInfo.cpp
+++ b/widget/windows/GfxInfo.cpp
@@ -588,17 +588,17 @@ GfxInfo::Init()
     // the driver version is less than knownSafeMismatchVersion.  See the
     // above comment about crashes with old mismatches.  If the GetDllVersion
     // call fails, we are not calling it a mismatch.
     if ((dllNumericVersion != 0 && dllNumericVersion != driverNumericVersion) ||
         (dllNumericVersion2 != 0 && dllNumericVersion2 != driverNumericVersion)) {
       if (driverNumericVersion < knownSafeMismatchVersion ||
           std::max(dllNumericVersion, dllNumericVersion2) < knownSafeMismatchVersion) {
         mHasDriverVersionMismatch = true;
-        gfxWarningOnce() << "Mismatched driver versions between the registry " << mDriverVersion[mActiveGPUIndex].get() << " and DLL(s) " << NS_ConvertUTF16toUTF8(dllVersion).get() << ", " << NS_ConvertUTF16toUTF8(dllVersion2).get() << " reported.";
+        gfxCriticalNoteOnce << "Mismatched driver versions between the registry " << mDriverVersion[mActiveGPUIndex].get() << " and DLL(s) " << NS_ConvertUTF16toUTF8(dllVersion).get() << ", " << NS_ConvertUTF16toUTF8(dllVersion2).get() << " reported.";
       }
     } else if (dllNumericVersion == 0 && dllNumericVersion2 == 0) {
       // Leave it as an asserting error for now, to see if we can find
       // a system that exhibits this kind of a problem internally.
       gfxCriticalErrorOnce() << "Potential driver version mismatch ignored due to missing DLLs " << NS_ConvertUTF16toUTF8(dllVersion).get() << " and " << NS_ConvertUTF16toUTF8(dllVersion2).get();
     }
   }