Bug 1336507 - Part 4: Stop using a magic constant here. r?drno
MozReview-Commit-ID: LgIUrzFFT8I
--- a/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
@@ -562,33 +562,35 @@ PeerConnectionConfiguration::AddIceServe
return NS_ERROR_FAILURE;
path.Mid(host, hostPos, hostLen);
}
if (port == -1)
port = (isStuns || isTurns)? 5349 : 3478;
if (isStuns || isTurns) {
// Should we barf if transport is set to udp or something?
- transport = "tls";
+ transport = kNrIceTransportTls;
+ }
+
+ if (transport.IsEmpty()) {
+ transport = kNrIceTransportUdp;
}
if (isTurn || isTurns) {
NS_ConvertUTF16toUTF8 credential(aServer.mCredential.Value());
NS_ConvertUTF16toUTF8 username(aServer.mUsername.Value());
if (!addTurnServer(host.get(), port,
username.get(),
credential.get(),
- (transport.IsEmpty() ?
- kNrIceTransportUdp : transport.get()))) {
+ transport.get())) {
return NS_ERROR_FAILURE;
}
} else {
- if (!addStunServer(host.get(), port, (transport.IsEmpty() ?
- kNrIceTransportUdp : transport.get()))) {
+ if (!addStunServer(host.get(), port, transport.get())) {
return NS_ERROR_FAILURE;
}
}
}
return NS_OK;
}
#endif