Bug 1336530 - Re-enable Android tests that were disabled in bug 1298218 and disable the assertion. r?tnikkel draft
authorMarkus Stange <mstange@themasta.com>
Fri, 03 Feb 2017 14:55:51 -0500
changeset 470475 1d5a0cd395cab58187fd84d59a9264ac24180a50
parent 470474 364e26c1f0a48f612818e253e35587d411832194
child 481893 4136250faafb11f59bf4715bdbd63dd58870cf4b
push id44042
push userbmo:mstange@themasta.com
push dateFri, 03 Feb 2017 19:56:27 +0000
reviewerstnikkel
bugs1336530, 1298218
milestone54.0a1
Bug 1336530 - Re-enable Android tests that were disabled in bug 1298218 and disable the assertion. r?tnikkel MozReview-Commit-ID: L7PnRvUkw5O
gfx/layers/apz/test/mochitest/mochitest.ini
layout/painting/FrameLayerBuilder.cpp
--- a/gfx/layers/apz/test/mochitest/mochitest.ini
+++ b/gfx/layers/apz/test/mochitest/mochitest.ini
@@ -37,28 +37,25 @@
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_bug1253683.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_bug1277814.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_bug1304689.html]
 [test_bug1304689-2.html]
 [test_frame_reconstruction.html]
-  skip-if = (toolkit == 'android') # Test was permafailing on mobile after bug 1298218
 [test_group_mouseevents.html]
   skip-if = (toolkit == 'android') # mouse events not supported on mobile
 [test_group_pointerevents.html]
-  skip-if = (toolkit == 'android') # Test was permafailing on mobile after bug 1298218
 [test_group_touchevents.html]
 [test_group_wheelevents.html]
   skip-if = (toolkit == 'android') # wheel events not supported on mobile
 [test_group_zoom.html]
   skip-if = (toolkit != 'android') # only android supports zoom
 [test_interrupted_reflow.html]
-  skip-if = (toolkit == 'android') # Test was permafailing on mobile after bug 1298218
 [test_layerization.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_scroll_inactive_bug1190112.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_scroll_inactive_flattened_frame.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_scroll_subframe_scrollbar.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
--- a/layout/painting/FrameLayerBuilder.cpp
+++ b/layout/painting/FrameLayerBuilder.cpp
@@ -5224,17 +5224,19 @@ ContainerState::PostprocessRetainedLayer
 
 void
 ContainerState::Finish(uint32_t* aTextContentFlags,
                        const nsIntRect& aContainerPixelBounds,
                        nsDisplayList* aChildItems, bool* aHasComponentAlphaChildren)
 {
   mPaintedLayerDataTree.Finish();
 
-  if (!mParameters.mForEventsAndPluginsOnly) {
+  if (!mParameters.mForEventsAndPluginsOnly && !gfxPrefs::LayoutUseContainersForRootFrames()) {
+    // Bug 1336544 tracks re-enabling this assertion in the
+    // gfxPrefs::LayoutUseContainersForRootFrames() case.
     NS_ASSERTION(mContainerBounds.IsEqualInterior(mAccumulatedChildBounds),
                  "Bounds computation mismatch");
   }
 
   if (mLayerBuilder->IsBuildingRetainedLayers()) {
     nsIntRegion containerOpaqueRegion;
     PostprocessRetainedLayers(&containerOpaqueRegion);
     if (containerOpaqueRegion.Contains(aContainerPixelBounds)) {