Bug 1334027 - Add unloaded modules and process/thread data to minidumps. r?ted draft bug-1334027
authorTing-Yu Chou <janus926@gmail.com>
Thu, 02 Feb 2017 09:33:01 +0800
changeset 469320 0de5ab97798c30ffb92c90fa460bd65395a4dc8c
parent 469313 ece0e0fd16a30d37249a18c41fa65143d7c01b8f
child 544161 00890fc033bfea6fe0ea0eb36aea37dabafab003
push id43686
push userbmo:janus926@gmail.com
push dateThu, 02 Feb 2017 01:55:18 +0000
reviewersted
bugs1334027
milestone54.0a1
Bug 1334027 - Add unloaded modules and process/thread data to minidumps. r?ted MozReview-Commit-ID: LpiE5f9dYqM
toolkit/crashreporter/nsExceptionHandler.cpp
--- a/toolkit/crashreporter/nsExceptionHandler.cpp
+++ b/toolkit/crashreporter/nsExceptionHandler.cpp
@@ -1500,16 +1500,25 @@ MINIDUMP_TYPE GetMinidumpType()
       VerQueryValue(&buffer[0], L"\\", (void**)&file_info, &len);
       WORD major = HIWORD(file_info->dwFileVersionMS),
         minor = LOWORD(file_info->dwFileVersionMS),
         revision = HIWORD(file_info->dwFileVersionLS);
       if (major > 6 || (major == 6 && minor > 1) ||
           (major == 6 && minor == 1 && revision >= 7600)) {
         minidump_type = MiniDumpWithFullMemoryInfo;
       }
+#ifdef NIGHTLY_BUILD
+      // TODO: Remove the NIGHTLY_BUILD wrapping if the increased size is
+      // accetable.
+      if (major > 5 || (major == 5 && minor > 1)) {
+        minidump_type = static_cast<MINIDUMP_TYPE>(minidump_type |
+            MiniDumpWithUnloadedModules |
+            MiniDumpWithProcessThreadData);
+      }
+#endif
     }
   }
 
   const char* e = PR_GetEnv("MOZ_CRASHREPORTER_FULLDUMP");
   if (e && *e) {
     minidump_type = MiniDumpWithFullMemory;
   }