Bug 1334104 - 'if' statement is unnecessary draft
authorCliff <cliffplaysdrums@gmail.com>
Mon, 30 Jan 2017 19:38:40 -0500
changeset 468313 e1cc12f5d1d1e95c93b5590fecb52439f721e6ad
parent 467839 919bc66915551aa6f097086ddf20426e82cecad3
child 543898 e334f140822afeacd05711a47066fa319f9663e6
push id43411
push userbmo:cliffplaysdrums@gmail.com
push dateTue, 31 Jan 2017 00:39:11 +0000
bugs1334104
milestone54.0a1
Bug 1334104 - 'if' statement is unnecessary Removed unnecessary `if` statements intended to safely delete pointers. Deleting a null pointer has no effect, and the behavior is defined. MozReview-Commit-ID: ATqITmpJYqY
dom/plugins/base/nsPluginHost.cpp
--- a/dom/plugins/base/nsPluginHost.cpp
+++ b/dom/plugins/base/nsPluginHost.cpp
@@ -3144,17 +3144,17 @@ nsPluginHost::ReadPluginInfo()
       filename,
       fullpath,
       version,
       (const char* const*)mimetypes,
       (const char* const*)mimedescriptions,
       (const char* const*)extensions,
       mimetypecount, lastmod, fromExtension, true);
 
-      delete [] heapalloced;
+    delete [] heapalloced;
 
     // Import flags from registry into prefs for old registry versions
     MOZ_LOG(nsPluginLogging::gPluginLog, PLUGIN_LOG_BASIC,
       ("LoadCachedPluginsInfo : Loading Cached plugininfo for %s\n", tag->FileName().get()));
 
     if (!ShouldAddPlugin(tag)) {
       continue;
     }