Bug 1334977 - Checking mVRSystem is not nullptr before scannibg OpenVR controllers; r?kip
MozReview-Commit-ID: 6ViJqGp82t2
--- a/gfx/vr/gfxVROpenVR.cpp
+++ b/gfx/vr/gfxVROpenVR.cpp
@@ -622,22 +622,22 @@ VRSystemManagerOpenVR::GetControllers(ns
for (uint32_t i = 0; i < mOpenVRController.Length(); ++i) {
aControllerResult.AppendElement(mOpenVRController[i]);
}
}
void
VRSystemManagerOpenVR::ScanForControllers()
{
- if (!mOpenVRInstalled) {
+ // mVRSystem is available after VRDisplay is created
+ // at GetHMDs().
+ if (!mVRSystem) {
return;
}
- MOZ_ASSERT(mVRSystem);
-
vr::TrackedDeviceIndex_t trackedIndexArray[vr::k_unMaxTrackedDeviceCount];
uint32_t newControllerCount = 0;
// Basically, we would have HMDs in the tracked devices,
// but we are just interested in the controllers.
for (vr::TrackedDeviceIndex_t trackedDevice = vr::k_unTrackedDeviceIndex_Hmd + 1;
trackedDevice < vr::k_unMaxTrackedDeviceCount; ++trackedDevice) {
if (!mVRSystem->IsTrackedDeviceConnected(trackedDevice)) {