Bug 1334330 - Part 3: stylo: Use GenericSpecifiedValue abstraction in elements using only common mappers; r?emilio
MozReview-Commit-ID: B8vg4ZiqRGK
--- a/dom/html/HTMLDivElement.cpp
+++ b/dom/html/HTMLDivElement.cpp
@@ -55,31 +55,29 @@ HTMLDivElement::ParseAttribute(int32_t a
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLDivElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLElement::MapDivAlignAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapDivAlignAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
}
static void
-MapMarqueeAttributesIntoRule(const nsMappedAttributes* aAttributes, GenericSpecifiedValues* aGenericData)
+MapMarqueeAttributesIntoRule(const nsMappedAttributes* aAttributes, GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLElement::MapImageMarginAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapBGColorInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapImageMarginAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
+ nsGenericHTMLElement::MapBGColorInto(aAttributes, aData);
}
NS_IMETHODIMP_(bool)
HTMLDivElement::IsAttributeMapped(const nsIAtom* aAttribute) const
{
if (mNodeInfo->Equals(nsGkAtoms::div)) {
static const MappedAttributeEntry* const map[] = {
sDivAlignAttributeMap,
--- a/dom/html/HTMLHeadingElement.cpp
+++ b/dom/html/HTMLHeadingElement.cpp
@@ -41,21 +41,20 @@ HTMLHeadingElement::ParseAttribute(int32
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLHeadingElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLElement::MapDivAlignAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapDivAlignAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
}
NS_IMETHODIMP_(bool)
HTMLHeadingElement::IsAttributeMapped(const nsIAtom* aAttribute) const
{
static const MappedAttributeEntry* const map[] = {
sDivAlignAttributeMap,
sCommonAttributeMap
--- a/dom/html/HTMLImageElement.cpp
+++ b/dom/html/HTMLImageElement.cpp
@@ -314,24 +314,23 @@ HTMLImageElement::ParseAttribute(int32_t
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLImageElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLElement::MapImageAlignAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageBorderAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageMarginAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapImageAlignAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageBorderAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageMarginAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
}
nsChangeHint
HTMLImageElement::GetAttributeChangeHint(const nsIAtom* aAttribute,
int32_t aModType) const
{
nsChangeHint retval =
nsGenericHTMLElement::GetAttributeChangeHint(aAttribute, aModType);
--- a/dom/html/HTMLInputElement.cpp
+++ b/dom/html/HTMLInputElement.cpp
@@ -5907,30 +5907,29 @@ HTMLInputElement::ParseAttribute(int32_t
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLInputElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
-{
- nsRuleData* aData = aGenericData->AsRuleData();
+ GenericSpecifiedValues* aData)
+{
const nsAttrValue* value = aAttributes->GetAttr(nsGkAtoms::type);
if (value && value->Type() == nsAttrValue::eEnum &&
value->GetEnumValue() == NS_FORM_INPUT_IMAGE) {
- nsGenericHTMLFormElementWithState::MapImageBorderAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLFormElementWithState::MapImageMarginAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLFormElementWithState::MapImageSizeAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLFormElementWithState::MapImageBorderAttributeInto(aAttributes, aData);
+ nsGenericHTMLFormElementWithState::MapImageMarginAttributeInto(aAttributes, aData);
+ nsGenericHTMLFormElementWithState::MapImageSizeAttributesInto(aAttributes, aData);
// Images treat align as "float"
- nsGenericHTMLFormElementWithState::MapImageAlignAttributeInto(aAttributes, aGenericData);
- }
-
- nsGenericHTMLFormElementWithState::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLFormElementWithState::MapImageAlignAttributeInto(aAttributes, aData);
+ }
+
+ nsGenericHTMLFormElementWithState::MapCommonAttributesInto(aAttributes, aData);
}
nsChangeHint
HTMLInputElement::GetAttributeChangeHint(const nsIAtom* aAttribute,
int32_t aModType) const
{
nsChangeHint retval =
nsGenericHTMLFormElementWithState::GetAttributeChangeHint(aAttribute, aModType);
--- a/dom/html/HTMLObjectElement.cpp
+++ b/dom/html/HTMLObjectElement.cpp
@@ -500,23 +500,23 @@ HTMLObjectElement::ParseAttribute(int32_
}
return nsGenericHTMLFormElement::ParseAttribute(aNamespaceID, aAttribute,
aValue, aResult);
}
void
HTMLObjectElement::MapAttributesIntoRule(const nsMappedAttributes *aAttributes,
- GenericSpecifiedValues *aGenericData)
+ GenericSpecifiedValues *aData)
{
- nsGenericHTMLFormElement::MapImageAlignAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLFormElement::MapImageBorderAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLFormElement::MapImageMarginAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLFormElement::MapImageSizeAttributesInto(aAttributes, aGenericData);
- nsGenericHTMLFormElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLFormElement::MapImageAlignAttributeInto(aAttributes, aData);
+ nsGenericHTMLFormElement::MapImageBorderAttributeInto(aAttributes, aData);
+ nsGenericHTMLFormElement::MapImageMarginAttributeInto(aAttributes, aData);
+ nsGenericHTMLFormElement::MapImageSizeAttributesInto(aAttributes, aData);
+ nsGenericHTMLFormElement::MapCommonAttributesInto(aAttributes, aData);
}
NS_IMETHODIMP_(bool)
HTMLObjectElement::IsAttributeMapped(const nsIAtom *aAttribute) const
{
static const MappedAttributeEntry* const map[] = {
sCommonAttributeMap,
sImageMarginSizeAttributeMap,
--- a/dom/html/HTMLParagraphElement.cpp
+++ b/dom/html/HTMLParagraphElement.cpp
@@ -39,21 +39,20 @@ HTMLParagraphElement::ParseAttribute(int
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLParagraphElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLElement::MapDivAlignAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapDivAlignAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
}
NS_IMETHODIMP_(bool)
HTMLParagraphElement::IsAttributeMapped(const nsIAtom* aAttribute) const
{
static const MappedAttributeEntry* const map[] = {
sDivAlignAttributeMap,
sCommonAttributeMap,
--- a/dom/html/HTMLSelectElement.cpp
+++ b/dom/html/HTMLSelectElement.cpp
@@ -1407,21 +1407,20 @@ HTMLSelectElement::ParseAttribute(int32_
}
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLSelectElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLFormElementWithState::MapImageAlignAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLFormElementWithState::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLFormElementWithState::MapImageAlignAttributeInto(aAttributes, aData);
+ nsGenericHTMLFormElementWithState::MapCommonAttributesInto(aAttributes, aData);
}
nsChangeHint
HTMLSelectElement::GetAttributeChangeHint(const nsIAtom* aAttribute,
int32_t aModType) const
{
nsChangeHint retval =
nsGenericHTMLFormElementWithState::GetAttributeChangeHint(aAttribute, aModType);
--- a/dom/html/HTMLSharedObjectElement.cpp
+++ b/dom/html/HTMLSharedObjectElement.cpp
@@ -254,38 +254,38 @@ HTMLSharedObjectElement::ParseAttribute(
}
return nsGenericHTMLElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
static void
MapAttributesIntoRuleBase(const nsMappedAttributes *aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsGenericHTMLElement::MapImageBorderAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageMarginAttributeInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapImageAlignAttributeInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapImageBorderAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageMarginAttributeInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aData);
+ nsGenericHTMLElement::MapImageAlignAttributeInto(aAttributes, aData);
}
static void
MapAttributesIntoRuleExceptHidden(const nsMappedAttributes *aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- MapAttributesIntoRuleBase(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesIntoExceptHidden(aAttributes, aGenericData);
+ MapAttributesIntoRuleBase(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesIntoExceptHidden(aAttributes, aData);
}
void
HTMLSharedObjectElement::MapAttributesIntoRule(const nsMappedAttributes *aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- MapAttributesIntoRuleBase(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ MapAttributesIntoRuleBase(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
}
NS_IMETHODIMP_(bool)
HTMLSharedObjectElement::IsAttributeMapped(const nsIAtom *aAttribute) const
{
static const MappedAttributeEntry* const map[] = {
sCommonAttributeMap,
sImageMarginSizeAttributeMap,
--- a/dom/html/HTMLVideoElement.cpp
+++ b/dom/html/HTMLVideoElement.cpp
@@ -93,21 +93,20 @@ HTMLVideoElement::ParseAttribute(int32_t
}
return HTMLMediaElement::ParseAttribute(aNamespaceID, aAttribute, aValue,
aResult);
}
void
HTMLVideoElement::MapAttributesIntoRule(const nsMappedAttributes* aAttributes,
- GenericSpecifiedValues* aGenericData)
+ GenericSpecifiedValues* aData)
{
- nsRuleData* aData = aGenericData->AsRuleData();
- nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aGenericData);
- nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aGenericData);
+ nsGenericHTMLElement::MapImageSizeAttributesInto(aAttributes, aData);
+ nsGenericHTMLElement::MapCommonAttributesInto(aAttributes, aData);
}
NS_IMETHODIMP_(bool)
HTMLVideoElement::IsAttributeMapped(const nsIAtom* aAttribute) const
{
static const MappedAttributeEntry attributes[] = {
{ &nsGkAtoms::width },
{ &nsGkAtoms::height },