Bug 1313933 - Cleanup logging in RDM tab remoteness test. r=ochameau draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Thu, 26 Jan 2017 16:27:07 -0600
changeset 467532 271f1b04981006e936ae71e12e24f6646fadac25
parent 466286 24d9eb148461bb4789848b9880867c63c783a2ca
child 467533 957f65ae6c97f27041b15d0790f8991da4be9747
push id43204
push userbmo:jryans@gmail.com
push dateFri, 27 Jan 2017 23:02:24 +0000
reviewersochameau
bugs1313933
milestone54.0a1
Bug 1313933 - Cleanup logging in RDM tab remoteness test. r=ochameau MozReview-Commit-ID: LSZGbhd6wg7
devtools/client/responsive.html/test/browser/browser_tab_remoteness_change.js
devtools/client/responsive.html/test/browser/head.js
--- a/devtools/client/responsive.html/test/browser/browser_tab_remoteness_change.js
+++ b/devtools/client/responsive.html/test/browser/browser_tab_remoteness_change.js
@@ -36,9 +36,10 @@ add_task(function* () {
   yield load(tab.linkedBrowser, "about:robots");
 
   // This flag is set at the end of `ResponsiveUI.destroy`.  If it is true without
   // yielding on `closeRDM` itself and only removing the tab, then we must have closed
   // synchronously in response to tab closing.
   is(ui.destroyed, true, "RDM closed synchronously");
 
   yield clientClosed;
+  yield removeTab(tab);
 });
--- a/devtools/client/responsive.html/test/browser/head.js
+++ b/devtools/client/responsive.html/test/browser/head.js
@@ -360,18 +360,21 @@ function addDeviceForTest(device) {
   registerCleanupFunction(() => {
     // Note that assertions in cleanup functions are not displayed unless they failed.
     ok(removeDevice(device), `Removed Test Device "${device.name}" from the list.`);
   });
 }
 
 function waitForClientClose(ui) {
   return new Promise(resolve => {
-    info("RDM's debugger client is now closed");
-    ui.client.addOneTimeListener("closed", resolve);
+    info("Waiting for RDM debugger client to close");
+    ui.client.addOneTimeListener("closed", () => {
+      info("RDM's debugger client is now closed");
+      resolve();
+    });
   });
 }
 
 function* testTouchEventsOverride(ui, expected) {
   let { document } = ui.toolWindow;
   let touchButton = document.querySelector("#global-touch-simulation-button");
 
   let flag = yield ui.emulationFront.getTouchEventsOverride();