Bug 1334079 - prevent memory leak in CreateSession. r?cpearce draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Thu, 26 Jan 2017 14:18:07 +0200
changeset 466720 3cf2f683789b493ef7ac75859d0117b5f7455d7a
parent 466606 fbdfcecf0c774d2221f11aed5a504d5591c774e0
child 543499 5992f3d53aad76123293900bfab470c98bbe6e4b
push id42978
push userbmo:bpostelnicu@mozilla.com
push dateThu, 26 Jan 2017 12:18:41 +0000
reviewerscpearce
bugs1334079
milestone54.0a1
Bug 1334079 - prevent memory leak in CreateSession. r?cpearce MozReview-Commit-ID: 7aaEkFcmiZF
media/gmp-clearkey/0.1/ClearKeySessionManager.cpp
--- a/media/gmp-clearkey/0.1/ClearKeySessionManager.cpp
+++ b/media/gmp-clearkey/0.1/ClearKeySessionManager.cpp
@@ -136,16 +136,17 @@ ClearKeySessionManager::CreateSession(ui
     CK_LOGD("Failed to initialize session: %s", sessionId.c_str());
 
     const static char* message = "Failed to initialize session";
     mHost->OnRejectPromise(aPromiseId,
                            Error::kUnknownError,
                            0,
                            message,
                            strlen(message));
+    delete session;
 
     return;
   }
 
   mSessions[sessionId] = session;
 
   const vector<KeyId>& sessionKeys = session->GetKeyIds();
   vector<KeyId> neededKeys;