Bug 1191130 - Make sure we wait for the initial load of new tabs in browser_contentSearchUI.js. r=adw draft
authorNihanth Subramanya <nhnt11@gmail.com>
Wed, 25 Jan 2017 16:14:42 +0530
changeset 466130 3919d8fb7778e1d6cb96b4243775d1cb29dc1d23
parent 465527 8ff550409e1d1f8b54f6f7f115545dbef857be0b
child 543340 e3e21cdbea4a6a3b2dd6cf16070ab25d9b118c71
push id42810
push usernhnt11@gmail.com
push dateWed, 25 Jan 2017 10:46:43 +0000
reviewersadw
bugs1191130
milestone54.0a1
Bug 1191130 - Make sure we wait for the initial load of new tabs in browser_contentSearchUI.js. r=adw MozReview-Commit-ID: 5SAabvz0hAZ
browser/base/content/test/general/browser_contentSearchUI.js
--- a/browser/base/content/test/general/browser_contentSearchUI.js
+++ b/browser/base/content/test/general/browser_contentSearchUI.js
@@ -709,21 +709,20 @@ function checkState(actualState, expecte
     expectedState.selectedButtonIndex = expectedSelectedIdx - expectedSuggestions.length;
   }
 
   SimpleTest.isDeeply(actualState, expectedState, "State");
 }
 
 var gMsgMan;
 
-function promiseTab() {
+function* promiseTab() {
   let deferred = Promise.defer();
-  let tab = gBrowser.addTab();
-  registerCleanupFunction(() => gBrowser.removeTab(tab));
-  gBrowser.selectedTab = tab;
+  let tab = yield BrowserTestUtils.openNewForegroundTab(gBrowser);
+  registerCleanupFunction(() => BrowserTestUtils.removeTab(tab));
   let pageURL = getRootDirectory(gTestPath) + TEST_PAGE_BASENAME;
   tab.linkedBrowser.addEventListener("load", function onLoad(event) {
     tab.linkedBrowser.removeEventListener("load", onLoad, true);
     gMsgMan = tab.linkedBrowser.messageManager;
     gMsgMan.sendAsyncMessage("ContentSearch", {
       type: "AddToWhitelist",
       data: [pageURL],
     });