Bug 1224207 - Part 3. Remove unused parameters of nsFilterInstance's member functions.
MozReview-Commit-ID: 4QcutMJveUy
--- a/layout/svg/nsFilterInstance.cpp
+++ b/layout/svg/nsFilterInstance.cpp
@@ -357,18 +357,17 @@ nsFilterInstance::ComputeNeededBoxes()
sourceGraphicNeededRegion.And(sourceGraphicNeededRegion, mTargetBounds);
mSourceGraphic.mNeededBounds = sourceGraphicNeededRegion.GetBounds();
mFillPaint.mNeededBounds = fillPaintNeededRegion.GetBounds();
mStrokePaint.mNeededBounds = strokePaintNeededRegion.GetBounds();
}
DrawResult
-nsFilterInstance::BuildSourcePaint(SourceInfo *aSource,
- DrawTarget* aTargetDT)
+nsFilterInstance::BuildSourcePaint(SourceInfo *aSource)
{
MOZ_ASSERT(mTargetFrame);
nsIntRect neededRect = aSource->mNeededBounds;
RefPtr<DrawTarget> offscreenDT =
gfxPlatform::GetPlatform()->CreateOffscreenContentDrawTarget(
neededRect.Size(), SurfaceFormat::B8G8R8A8);
if (!offscreenDT || !offscreenDT->IsValid()) {
@@ -405,37 +404,37 @@ nsFilterInstance::BuildSourcePaint(Sourc
aSource->mSourceSurface = offscreenDT->Snapshot();
aSource->mSurfaceRect = neededRect;
return DrawResult::SUCCESS;
}
DrawResult
-nsFilterInstance::BuildSourcePaints(DrawTarget* aTargetDT)
+nsFilterInstance::BuildSourcePaints()
{
if (!mFillPaint.mNeededBounds.IsEmpty()) {
- DrawResult result = BuildSourcePaint(&mFillPaint, aTargetDT);
+ DrawResult result = BuildSourcePaint(&mFillPaint);
if (result != DrawResult::SUCCESS) {
return result;
}
}
if (!mStrokePaint.mNeededBounds.IsEmpty()) {
- DrawResult result = BuildSourcePaint(&mStrokePaint, aTargetDT);
+ DrawResult result = BuildSourcePaint(&mStrokePaint);
if (result != DrawResult::SUCCESS) {
return result;
}
}
return DrawResult::SUCCESS;
}
DrawResult
-nsFilterInstance::BuildSourceImage(DrawTarget* aTargetDT)
+nsFilterInstance::BuildSourceImage()
{
MOZ_ASSERT(mTargetFrame);
nsIntRect neededRect = mSourceGraphic.mNeededBounds;
if (neededRect.IsEmpty()) {
return DrawResult::SUCCESS;
}
@@ -506,21 +505,21 @@ nsFilterInstance::Render(DrawTarget* aDr
}
AutoRestoreTransform autoRestoreTransform(aDrawTarget);
Matrix newTM = ToMatrix(ctm).PreTranslate(filterRect.x, filterRect.y) *
aDrawTarget->GetTransform();
aDrawTarget->SetTransform(newTM);
ComputeNeededBoxes();
- DrawResult result = BuildSourceImage(aDrawTarget);
+ DrawResult result = BuildSourceImage();
if (result != DrawResult::SUCCESS){
return result;
}
- result = BuildSourcePaints(aDrawTarget);
+ result = BuildSourcePaints();
if (result != DrawResult::SUCCESS){
return result;
}
FilterSupport::RenderFilterDescription(
aDrawTarget, mFilterDescription, IntRectToRect(filterRect),
mSourceGraphic.mSourceSurface, mSourceGraphic.mSurfaceRect,
mFillPaint.mSourceSurface, mFillPaint.mSurfaceRect,
--- a/layout/svg/nsFilterInstance.h
+++ b/layout/svg/nsFilterInstance.h
@@ -223,31 +223,30 @@ private:
// Set by BuildSourceImage / BuildSourcePaint.
IntRect mSurfaceRect;
};
/**
* Creates a SourceSurface for either the FillPaint or StrokePaint graph
* nodes
*/
- DrawResult BuildSourcePaint(SourceInfo *aPrimitive,
- DrawTarget* aTargetDT);
+ DrawResult BuildSourcePaint(SourceInfo *aPrimitive);
/**
* Creates a SourceSurface for either the FillPaint and StrokePaint graph
* nodes, fills its contents and assigns it to mFillPaint.mSourceSurface and
* mStrokePaint.mSourceSurface respectively.
*/
- DrawResult BuildSourcePaints(DrawTarget* aTargetDT);
+ DrawResult BuildSourcePaints();
/**
* Creates the SourceSurface for the SourceGraphic graph node, paints its
* contents, and assigns it to mSourceGraphic.mSourceSurface.
*/
- DrawResult BuildSourceImage(DrawTarget* aTargetDT);
+ DrawResult BuildSourceImage();
/**
* Build the list of FilterPrimitiveDescriptions that describes the filter's
* filter primitives and their connections. This populates
* mPrimitiveDescriptions and mInputImages. aFilterInputIsTainted describes
* whether the SourceGraphic is tainted.
*/
nsresult BuildPrimitives(const nsTArray<nsStyleFilter>& aFilterChain,