Bug 1333262 Set notification text unconditionally r?florian draft
authorAndrew Swan <aswan@mozilla.com>
Mon, 23 Jan 2017 18:07:25 -0800
changeset 466969 c4520c954f2fbd77d3067fcd09f9a0b987c92722
parent 464990 5a4412474c63e1d9e66036d603ac42e9cb2b9150
child 543592 5c63959925ad44256b8da743a7d9ab3a43be2fce
push id43074
push useraswan@mozilla.com
push dateFri, 27 Jan 2017 00:03:33 +0000
reviewersflorian
bugs1333262
milestone54.0a1
Bug 1333262 Set notification text unconditionally r?florian MozReview-Commit-ID: DzzZaKWXrV8
browser/modules/ExtensionsUI.jsm
--- a/browser/modules/ExtensionsUI.jsm
+++ b/browser/modules/ExtensionsUI.jsm
@@ -258,19 +258,19 @@ this.ExtensionsUI = {
       popupIconURL: info.icon,
       persistent: true,
 
       eventCallback(topic) {
         if (topic == "showing") {
           let doc = this.browser.ownerDocument;
           doc.getElementById("addon-webext-perm-header").innerHTML = header;
 
-          if (text) {
-            doc.getElementById("addon-webext-perm-text").innerHTML = text;
-          }
+          let textEl = doc.getElementById("addon-webext-perm-text");
+          textEl.innerHTML = text;
+          textEl.hidden = !text;
 
           let listIntroEl = doc.getElementById("addon-webext-perm-intro");
           listIntroEl.value = listIntro;
           listIntroEl.hidden = (msgs.length == 0);
 
           let list = doc.getElementById("addon-webext-perm-list");
           while (list.firstChild) {
             list.firstChild.remove();