Bug 1325409 - shield-recipe-client: Remove unnecessary cleanup r=me draft
authorMythmon <mcooper@mozilla.com>
Mon, 23 Jan 2017 15:26:10 -0800
changeset 465186 f96e80a031048c56e9d7926b28d543061a6ff466
parent 464990 5a4412474c63e1d9e66036d603ac42e9cb2b9150
child 543123 76c33ed6c83ce368a0707375aaf09343da12abea
push id42572
push userbmo:mcooper@mozilla.com
push dateMon, 23 Jan 2017 23:40:40 +0000
reviewersme
bugs1325409
milestone54.0a1
Bug 1325409 - shield-recipe-client: Remove unnecessary cleanup r=me See also: https://github.com/mozilla/normandy/pull/443/files MozReview-Commit-ID: 6LdFs4YdfMs
browser/extensions/shield-recipe-client/lib/Heartbeat.jsm
--- a/browser/extensions/shield-recipe-client/lib/Heartbeat.jsm
+++ b/browser/extensions/shield-recipe-client/lib/Heartbeat.jsm
@@ -326,17 +326,16 @@ this.Heartbeat = class {
   }
 
   handleWindowClosed() {
     this.maybeNotifyHeartbeat("WindowClosed");
   }
 
   close() {
     this.notificationBox.removeNotification(this.notice);
-    this.cleanup();
   }
 
   cleanup() {
     // Kill the timers which might call things after we've cleaned up:
     this.endTimerIfPresent("surveyEndTimer");
     this.endTimerIfPresent("engagementCloseTimer");
 
     this.sandboxManager.removeHold("heartbeat");