Bug 1332798 - Add null check after CreateIOSurface. r=mstange draft
authorMorris Tseng <mtseng@mozilla.com>
Mon, 23 Jan 2017 16:46:51 +0800
changeset 464891 dce8e71dc110fab50b1730433126e73b1fb13127
parent 464800 bd0cd9af94d9334b862d9891013fed56fb9b3b7c
child 543036 916b23735a602225b6ba22a480829e72bc812d80
push id42477
push userbmo:mtseng@mozilla.com
push dateMon, 23 Jan 2017 08:48:36 +0000
reviewersmstange
bugs1332798
milestone53.0a1
Bug 1332798 - Add null check after CreateIOSurface. r=mstange MozReview-Commit-ID: 6JIR8y04cXm
widget/cocoa/RectTextureImage.mm
--- a/widget/cocoa/RectTextureImage.mm
+++ b/widget/cocoa/RectTextureImage.mm
@@ -44,16 +44,20 @@ RectTextureImage::BeginUpdate(const Layo
   if (mUpdateRegion.IsEmpty()) {
     return nullptr;
   }
 
   if (!mIOSurface || needRecreate) {
     DeleteTexture();
     mIOSurface = MacIOSurface::CreateIOSurface(mBufferSize.width,
                                                mBufferSize.height);
+
+    if (!mIOSurface) {
+      return nullptr;
+    }
   }
 
   mInUpdate = true;
 
   mIOSurface->Lock(false);
   unsigned char* ioData = (unsigned char*)mIOSurface->GetBaseAddress();
   gfx::IntSize size(mBufferSize.width, mBufferSize.height);
   int32_t stride = mIOSurface->GetBytesPerRow();