Bug 1332868: Fix shutdown race in test_ext_contentscript_permission. r?krizsa draft
authorKris Maglione <maglione.k@gmail.com>
Sat, 21 Jan 2017 13:52:35 -0800
changeset 464696 f3769feba3eb268bad833fdc287b6ebe7a47569b
parent 464695 e0c6e132669599d585d417c25b971a91be202d85
child 542962 38cdd3961a9c76a873f57e7822c2cf34e21749e6
push id42400
push usermaglione.k@gmail.com
push dateSat, 21 Jan 2017 21:53:20 +0000
reviewerskrizsa
bugs1332868
milestone53.0a1
Bug 1332868: Fix shutdown race in test_ext_contentscript_permission. r?krizsa MozReview-Commit-ID: EVMcSdU3fTG
toolkit/components/extensions/test/mochitest/test_ext_contentscript_permission.html
--- a/toolkit/components/extensions/test/mochitest/test_ext_contentscript_permission.html
+++ b/toolkit/components/extensions/test/mochitest/test_ext_contentscript_permission.html
@@ -10,27 +10,29 @@
 </head>
 <body>
 
 <script type="text/javascript">
 "use strict";
 
 add_task(function* test_contentscript() {
   function background() {
-    browser.test.onMessage.addListener(url => {
-      browser.tabs.create({url}).then(tab => {
-        return browser.tabs.executeScript(tab.id, {code: "true;"})
-                      .then(() => {
-                        browser.test.sendMessage("executed", true);
-                        browser.tabs.remove([tab.id]);
-                      }, err => {
-                        browser.test.sendMessage("executed", false);
-                        browser.tabs.remove([tab.id]);
-                      });
-      });
+    browser.test.onMessage.addListener(async url => {
+      let tab = await browser.tabs.create({url});
+
+      let executed = true;
+      try {
+        await browser.tabs.executeScript(tab.id, {code: "true;"});
+      } catch (e) {
+        executed = false;
+      }
+
+      await browser.tabs.remove([tab.id]);
+
+      browser.test.sendMessage("executed", executed);
     });
   }
 
   let extensionData = {
     manifest: {
       permissions: ["<all_urls>"],
     },
     background,