MozReview: Specify ordering filediffs by id (Bug 1248008) r?smacleod draft
authorPiotr Zalewa <pzalewa@mozilla.com>
Fri, 06 Jan 2017 10:36:17 +0100
changeset 277 78e877c6dafcc08b58e355b7c171d5635707b997
parent 276 59310c0f53628c0c0fab63bb319720698bf1ebf5
child 278 9ce34694dbde7f3b7b985d7282fb848877f92254
child 280 b4e68deb6ca3a39c8bd9e735a2dddaf6601bad99
push idunknown
push userunknown
push dateunknown
reviewerssmacleod
bugs1248008
MozReview: Specify ordering filediffs by id (Bug 1248008) r?smacleod Backbone's set function performs a merge of the existing models, rather than fully replacing them (New items are added, missing items are removed, and existing items are merged). It appears this merge operation does not preserve the order of the models which are passed into set (instead the existing items end up before the others). Setting the comparator to id tells the set function to sort by that attribute. MozReview-Commit-ID: Buz561YZlf8
reviewboard/reviewboard/static/rb/js/diffviewer/collections/diffFileCollection_mozreview.js
--- a/reviewboard/reviewboard/static/rb/js/diffviewer/collections/diffFileCollection_mozreview.js
+++ b/reviewboard/reviewboard/static/rb/js/diffviewer/collections/diffFileCollection_mozreview.js
@@ -1,6 +1,7 @@
 /*
  * A collection of files.
  */
 RB.DiffFileCollection = Backbone.Collection.extend({
-    model: RB.DiffFile
+    model: RB.DiffFile,
+    comparator: 'id'
 });