Bug 1319485 - Pre: Add comment explaining missing migrations r?grisha
I might as well add this since I was doing some code archaelogy.
I suspect the original removal of that migration code was incorrect *if* we want
to be able to support correctly migrating old DB versions (since the view
gets orphaned), but I think that ship has sailed already.
MozReview-Commit-ID: IkrnW4fv0ir
--- a/mobile/android/base/java/org/mozilla/gecko/db/BrowserDatabaseHelper.java
+++ b/mobile/android/base/java/org/mozilla/gecko/db/BrowserDatabaseHelper.java
@@ -2017,16 +2017,23 @@ public final class BrowserDatabaseHelper
case 7:
upgradeDatabaseFrom6to7(db);
break;
case 8:
upgradeDatabaseFrom7to8(db);
break;
+ // 8->9 and 9->10 both dealt with dropping and recreating an obsolete VIEW_COMBINED_WITH_IMAGES,
+ // followed by completely dropping it again. This view was created in the 5->6 migration.
+ // Someone migrating from DB v8 or v9, to the latest DB, running this codebase, would
+ // would therefore presumably be left with an unused orphan VIEW_COMBINED_WITH_IMAGES.
+ // (Bug 947018 completely removed this code with the assumption that we no longer need to
+ // care because no users remained on those DB versions.)
+
case 11:
upgradeDatabaseFrom10to11(db);
break;
case 13:
upgradeDatabaseFrom12to13(db);
break;