Bug 1319485 - Pre: Add comment explaining missing migrations r?grisha draft
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 15 Dec 2016 11:21:27 -0800
changeset 468871 7533b71bf43d8ba2a10545ba40f299786cb41b95
parent 468635 7cb7f1d931609010a62b7f471ef3451aff5dddd1
child 468872 3a464281aea3e62dc87651336f50aa098415cd8e
push id43552
push userahunt@mozilla.com
push dateTue, 31 Jan 2017 23:29:38 +0000
reviewersgrisha
bugs1319485
milestone54.0a1
Bug 1319485 - Pre: Add comment explaining missing migrations r?grisha I might as well add this since I was doing some code archaelogy. I suspect the original removal of that migration code was incorrect *if* we want to be able to support correctly migrating old DB versions (since the view gets orphaned), but I think that ship has sailed already. MozReview-Commit-ID: IkrnW4fv0ir
mobile/android/base/java/org/mozilla/gecko/db/BrowserDatabaseHelper.java
--- a/mobile/android/base/java/org/mozilla/gecko/db/BrowserDatabaseHelper.java
+++ b/mobile/android/base/java/org/mozilla/gecko/db/BrowserDatabaseHelper.java
@@ -2017,16 +2017,23 @@ public final class BrowserDatabaseHelper
                 case 7:
                     upgradeDatabaseFrom6to7(db);
                     break;
 
                 case 8:
                     upgradeDatabaseFrom7to8(db);
                     break;
 
+                // 8->9 and 9->10 both dealt with dropping and recreating an obsolete VIEW_COMBINED_WITH_IMAGES,
+                // followed by completely dropping it again. This view was created in the 5->6 migration.
+                // Someone migrating from DB v8 or v9, to the latest DB, running this codebase, would
+                // would therefore presumably be left with an unused orphan VIEW_COMBINED_WITH_IMAGES.
+                // (Bug 947018 completely removed this code with the assumption that we no longer need to
+                // care because no users remained on those DB versions.)
+
                 case 11:
                     upgradeDatabaseFrom10to11(db);
                     break;
 
                 case 13:
                     upgradeDatabaseFrom12to13(db);
                     break;