Bug 1331554. Part 1 - print logs only when decoder.mIsBlankDecode is going to change. r?jya draft
authorJW Wang <jwwang@mozilla.com>
Mon, 16 Jan 2017 15:20:10 +0800
changeset 462934 7fe77ab83c965b5edeae8529f0082150cdf693b9
parent 462933 65c5201cf05a6d3347f6b90dde3708978cd27af1
child 462935 463f36ecbcd49b04185bf73272ec99b6405ca06b
push id41914
push userjwwang@mozilla.com
push dateWed, 18 Jan 2017 09:07:03 +0000
reviewersjya
bugs1331554
milestone53.0a1
Bug 1331554. Part 1 - print logs only when decoder.mIsBlankDecode is going to change. r?jya MozReview-Commit-ID: 9vExcUapFOb
dom/media/MediaFormatReader.cpp
--- a/dom/media/MediaFormatReader.cpp
+++ b/dom/media/MediaFormatReader.cpp
@@ -2721,25 +2721,25 @@ MediaFormatReader::SetVideoBlankDecode(b
   MOZ_ASSERT(OnTaskQueue());
   return SetBlankDecode(TrackType::kVideoTrack, aIsBlankDecode);
 }
 
 void
 MediaFormatReader::SetBlankDecode(TrackType aTrack, bool aIsBlankDecode)
 {
   MOZ_ASSERT(OnTaskQueue());
+
   auto& decoder = GetDecoderData(aTrack);
+  if (decoder.mIsBlankDecode == aIsBlankDecode) {
+    return;
+  }
 
   LOG("%s, decoder.mIsBlankDecode = %d => aIsBlankDecode = %d",
       TrackTypeToStr(aTrack), decoder.mIsBlankDecode, aIsBlankDecode);
 
-  if (decoder.mIsBlankDecode == aIsBlankDecode) {
-    return;
-  }
-
   decoder.mIsBlankDecode = aIsBlankDecode;
   decoder.Flush();
   decoder.ShutdownDecoder();
   ScheduleUpdate(TrackInfo::kVideoTrack);
 
   return;
 }