Bug 1320361 - Make PopupNotifications panels noautohide by default. r=past draft
authorNihanth Subramanya <nhnt11@gmail.com>
Mon, 16 Jan 2017 17:14:22 +0530
changeset 468109 de19b2b95e5e42b6546bdec6af29d2d8191c941e
parent 467834 71224049c0b52ab190564d3ea0eab089a159a4cf
child 543846 53d58c39aefe8b0fa67c4efb753edb9aebc7367b
push id43352
push usernhnt11@gmail.com
push dateMon, 30 Jan 2017 18:11:56 +0000
reviewerspast
bugs1320361
milestone54.0a1
Bug 1320361 - Make PopupNotifications panels noautohide by default. r=past MozReview-Commit-ID: vb2xTvyLHJ
browser/base/content/popup-notifications.inc
toolkit/modules/PopupNotifications.jsm
--- a/browser/base/content/popup-notifications.inc
+++ b/browser/base/content/popup-notifications.inc
@@ -1,16 +1,17 @@
 # to be included inside a popupset element
 
     <panel id="notification-popup"
            type="arrow"
            position="after_start"
            hidden="true"
            orient="vertical"
            noautofocus="true"
+           noautohide="true"
            role="alert"/>
 
     <popupnotification id="webRTC-shareDevices-notification" hidden="true">
       <popupnotificationcontent id="webRTC-selectCamera" orient="vertical">
         <label value="&getUserMedia.selectCamera.label;"
                accesskey="&getUserMedia.selectCamera.accesskey;"
                control="webRTC-selectCamera-menulist"/>
         <menulist id="webRTC-selectCamera-menulist">
--- a/toolkit/modules/PopupNotifications.jsm
+++ b/toolkit/modules/PopupNotifications.jsm
@@ -634,16 +634,17 @@ PopupNotifications.prototype = {
       if (notificationEl) {
         notificationEl.notification.options.persistent = false;
       }
     }
 
     let browser = this.panel.firstChild &&
                   this.panel.firstChild.notification.browser;
     this.panel.hidePopup();
+    this.panel.ownerGlobal.focus();
     if (browser)
       browser.focus();
   },
 
   /**
    * Hides the notification popup.
    */
   _hidePanel: function PopupNotifications_hide() {