bug 1331320 document requestFlakyTimeout for crashAndGetCrashServiceRecord() r?glandium draft
authorKarl Tomlinson <karlt+@karlt.net>
Mon, 16 Jan 2017 18:57:03 +1300
changeset 461230 82877d7c58b02b39284d0939bf960dfa64c607f4
parent 461229 783db564596d6445a94c1f61ae20e6f7ab8f0ee7
child 461231 96454ef7ea851555504fd2318e092a41500a7701
push id41604
push userktomlinson@mozilla.com
push dateMon, 16 Jan 2017 07:36:05 +0000
reviewersglandium
bugs1331320
milestone53.0a1
bug 1331320 document requestFlakyTimeout for crashAndGetCrashServiceRecord() r?glandium MozReview-Commit-ID: 4l2qxJfRbkq
dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
--- a/dom/plugins/test/mochitest/test_CrashService_crash.html
+++ b/dom/plugins/test/mochitest/test_CrashService_crash.html
@@ -1,17 +1,18 @@
 <head>
   <title>nsICrashService plugin crash</title>
   <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
   <script type="application/javascript" src="plugin-utils.js"></script>
 
 <body>
   <script class="testbody" type="application/javascript">
   SimpleTest.waitForExplicitFinish();
-  SimpleTest.requestFlakyTimeout("untriaged");
+  SimpleTest.requestFlakyTimeout(
+    "crashAndGetCrashServiceRecord() polls for async crash recording");
   SimpleTest.requestCompleteLog();
   setTestPluginEnabledState(SpecialPowers.Ci.nsIPluginTag.STATE_ENABLED);
 
   window.frameLoaded = function frameLoaded_toCrash() {
     SimpleTest.expectChildProcessCrash();
 
     crashAndGetCrashServiceRecord("crash", function (cm, crash) {
       var isPluginCrash = crash.isOfType(cm.PROCESS_TYPE_PLUGIN, cm.CRASH_TYPE_CRASH);
--- a/dom/plugins/test/mochitest/test_CrashService_hang.html
+++ b/dom/plugins/test/mochitest/test_CrashService_hang.html
@@ -1,17 +1,18 @@
 <head>
   <title>nsICrashService plugin hang</title>
   <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
   <script type="application/javascript" src="plugin-utils.js"></script>
 
 <body>
   <script class="testbody" type="application/javascript">
   SimpleTest.waitForExplicitFinish();
-  SimpleTest.requestFlakyTimeout("untriaged");
+  SimpleTest.requestFlakyTimeout(
+    "crashAndGetCrashServiceRecord() polls for async crash recording");
   SimpleTest.requestCompleteLog();
   setTestPluginEnabledState(SpecialPowers.Ci.nsIPluginTag.STATE_ENABLED);
 
   window.frameLoaded = function frameLoaded_toCrash() {
     SimpleTest.expectChildProcessCrash();
 
     // the default timeout is annoying high for mochitest runs
     var timeoutPref = "dom.ipc.plugins.timeoutSecs";