Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r?markh
MozReview-Commit-ID: 65EsZGCJPMD
--- a/services/.eslintrc.js
+++ b/services/.eslintrc.js
@@ -5,12 +5,11 @@ module.exports = {
"../toolkit/.eslintrc.js"
],
rules: {
/* These rules are only set to warn temporarily
until they get fixed, at which point their
respective line in this file should be removed. */
"consistent-return": "warn",
"no-func-assign": "warn",
- "no-native-reassign": "warn",
"no-nested-ternary": "warn",
}
};
--- a/services/sync/tests/unit/test_status.js
+++ b/services/sync/tests/unit/test_status.js
@@ -68,17 +68,17 @@ function run_test() {
// Check resetSync
Status.sync = SYNC_FAILED;
Status.resetSync();
do_check_eq(Status.service, STATUS_OK);
do_check_eq(Status.sync, SYNC_SUCCEEDED);
- for (name in Status.engines) {
+ if (Status.engines.length) {
do_throw("Status.engines should be empty.");
}
// Check resetBackoff
Status.enforceBackoff = true;
Status.backOffInterval = 4815162342;
Status.backOffInterval = 42;