Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors. r?markh draft
authorJared Wein <jwein@mozilla.com>
Thu, 12 Jan 2017 17:27:34 -0500
changeset 462643 ed1178f40c4cf4b841d6e29d7fbfc5b202378ffe
parent 462642 2998071bf4e1f9f8e234d99d7c014a773e4df9ad
child 462644 f87b0692a699dbd7d349b871171b2c51424ca16b
child 463687 35c83ef28265e6dd6e63313839563f1675e635ba
push id41837
push userjwein@mozilla.com
push dateTue, 17 Jan 2017 21:50:46 +0000
reviewersmarkh
bugs1330791
milestone53.0a1
Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors. r?markh MozReview-Commit-ID: 5rledRlxUl2
services/.eslintrc.js
services/sync/services-sync.js
services/sync/tps/extensions/tps/resource/tps.jsm
--- a/services/.eslintrc.js
+++ b/services/.eslintrc.js
@@ -10,17 +10,16 @@ module.exports = {
        respective line in this file should be removed. */
     "brace-style": "warn",
     "consistent-return": "warn",
     "no-cond-assign": "warn",
     "no-else-return": "warn",
     "no-empty": "warn",
     "no-ex-assign": "warn",
     "no-func-assign": "warn",
-    "no-irregular-whitespace": "warn",
     "no-native-reassign": "warn",
     "no-nested-ternary": "warn",
     "no-octal": "warn",
     "no-redeclare": "warn",
     "no-unreachable": "warn",
     "no-unsafe-finally": "warn",
     "no-unused-vars": "warn",
     "no-useless-call": "warn"
--- a/services/sync/services-sync.js
+++ b/services/sync/services-sync.js
@@ -86,10 +86,10 @@ pref("services.sync.telemetry.maxPayload
 // if we don't end up validating, we won't try again unless this much time has passed.
 pref("services.sync.validation.interval", 86400); // 24 hours in seconds
 
 // We only run validation `services.sync.validation.percentageChance` percent of
 // the time, even if it's been the right amount of time since the last validation,
 // and you meet the maxRecord checks.
 pref("services.sync.validation.percentageChance", 10);
 
-// We won't validate an engine if it has more than this many records on the server.
+// We won't validate an engine if it has more than this many records on the server.
 pref("services.sync.validation.maxRecords", 100);
--- a/services/sync/tps/extensions/tps/resource/tps.jsm
+++ b/services/sync/tps/extensions/tps/resource/tps.jsm
@@ -817,17 +817,17 @@ var TPS = {
       // so we load Ajv manually.
       let ajvFile = this._getFileRelativeToSourceRoot(testFile, "testing/modules/ajv-4.1.1.js");
       let ajvURL = fileProtocolHandler.getURLSpecFromFile(ajvFile);
       let ns = {};
       Cu.import(ajvURL, ns);
       let ajv = new ns.Ajv({ async: "co*" });
       this.pingValidator = ajv.compile(schema);
     } catch (e) {
-      this.DumpError(`Failed to load ping schema and AJV relative to "${testFile}".`, e);
+      this.DumpError(`Failed to load ping schema and AJV relative to "${testFile}".`, e);
     }
   },
 
   /**
    * Runs a single test phase.
    *
    * This is the main entry point for each phase of a test. The TPS command
    * line driver loads this module and calls into the function with the