Bug 1328937 - HighlightItem: Make all properties 'private'. r?grisha draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Thu, 05 Jan 2017 19:33:49 +0100
changeset 457650 a2a052006d1e8e64b92a5057293fd58143e47d6d
parent 457649 0fe1a8aba3ece1d3a7a9918deb1bbed0d0c9ab78
child 457651 18d953c94327375c30745e29161e04d3facb0845
push id40848
push users.kaspari@gmail.com
push dateMon, 09 Jan 2017 13:43:11 +0000
reviewersgrisha
bugs1328937
milestone53.0a1
Bug 1328937 - HighlightItem: Make all properties 'private'. r?grisha MozReview-Commit-ID: 9Ots1ZF8oZ8
mobile/android/base/java/org/mozilla/gecko/home/activitystream/stream/HighlightItem.java
--- a/mobile/android/base/java/org/mozilla/gecko/home/activitystream/stream/HighlightItem.java
+++ b/mobile/android/base/java/org/mozilla/gecko/home/activitystream/stream/HighlightItem.java
@@ -39,32 +39,31 @@ import java.util.concurrent.Future;
 
 import static org.mozilla.gecko.activitystream.ActivityStream.extractLabel;
 
 public class HighlightItem extends StreamItem implements IconCallback {
     private static final String LOGTAG = "GeckoHighlightItem";
 
     public static final int LAYOUT_ID = R.layout.activity_stream_card_history_item;
 
-    String title;
-    String url;
-    JSONObject metadata;
+    private String title;
+    private String url;
+    private JSONObject metadata;
 
-    @Nullable
-    Boolean isPinned;
-    @Nullable Boolean isBookmarked;
+    private @Nullable Boolean isPinned;
+    private @Nullable Boolean isBookmarked;
 
-    Utils.HighlightSource source;
+    private Utils.HighlightSource source;
 
-    final FaviconView vIconView;
-    final TextView vLabel;
-    final TextView vTimeSince;
-    final TextView vSourceView;
-    final TextView vPageView;
-    final ImageView vSourceIconView;
+    private final FaviconView vIconView;
+    private final TextView vLabel;
+    private final TextView vTimeSince;
+    private final TextView vSourceView;
+    private final TextView vPageView;
+    private final ImageView vSourceIconView;
 
     private Future<IconResponse> ongoingIconLoad;
     private int tilesMargin;
 
     public HighlightItem(final View itemView,
                          final HomePager.OnUrlOpenListener onUrlOpenListener,
                          final HomePager.OnUrlOpenInBackgroundListener onUrlOpenInBackgroundListener) {
         super(itemView);