Bug 1329098. Part 5 - remove unnecessary checks and temps. draft
authorJW Wang <jwwang@mozilla.com>
Fri, 06 Jan 2017 15:49:02 +0800
changeset 457499 c6ef60b26865bf1780587e86fec03427f320750d
parent 457498 44023d930e2cceb9cb7bfefd254ce57e49d3e5e6
child 541493 e44a805f2a5e1bdae3bb2b57bcccdfdf517cadbd
push id40791
push userjwwang@mozilla.com
push dateMon, 09 Jan 2017 03:31:36 +0000
bugs1329098
milestone53.0a1
Bug 1329098. Part 5 - remove unnecessary checks and temps. For mSentFirstFrameLoadedEvent is true in DecodingState. MozReview-Commit-ID: 8zpsMAME8p6
dom/media/MediaDecoderStateMachine.cpp
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -2041,31 +2041,25 @@ DecodingState::HandleEndOfStream()
     MaybeStopPrerolling();
   }
 }
 
 void
 MediaDecoderStateMachine::
 DecodingState::DispatchDecodeTasksIfNeeded()
 {
-  const bool needToDecodeAudio =
-    mMaster->IsAudioDecoding() &&
-    ((!mMaster->mSentFirstFrameLoadedEvent && AudioQueue().GetSize() == 0) ||
-     (!mMaster->mMinimizePreroll && !mMaster->HaveEnoughDecodedAudio()));
-
-  const bool needToDecodeVideo =
-    mMaster->IsVideoDecoding() &&
-    ((!mMaster->mSentFirstFrameLoadedEvent && VideoQueue().GetSize() == 0) ||
-     (!mMaster->mMinimizePreroll && !mMaster->HaveEnoughDecodedVideo()));
-
-  if (needToDecodeAudio) {
+  if (mMaster->IsAudioDecoding() &&
+      !mMaster->mMinimizePreroll &&
+      !mMaster->HaveEnoughDecodedAudio()) {
     mMaster->EnsureAudioDecodeTaskQueued();
   }
 
-  if (needToDecodeVideo) {
+  if (mMaster->IsVideoDecoding() &&
+      !mMaster->mMinimizePreroll &&
+      !mMaster->HaveEnoughDecodedVideo()) {
     mMaster->EnsureVideoDecodeTaskQueued();
   }
 }
 
 void
 MediaDecoderStateMachine::
 DecodingState::MaybeStartBuffering()
 {