Bug 1329098. Part 2 - remove unnecessary checks. draft
authorJW Wang <jwwang@mozilla.com>
Fri, 06 Jan 2017 15:22:52 +0800
changeset 457496 ce248528ce1b28c6d64bed9e0c824850837b6be8
parent 457495 cdc7a1f3941465745814d1807f6faec15e9d09b9
child 457497 71b221157db244a74f987a36a3e926be1f4fbe80
push id40791
push userjwwang@mozilla.com
push dateMon, 09 Jan 2017 03:31:36 +0000
bugs1329098
milestone53.0a1
Bug 1329098. Part 2 - remove unnecessary checks. 1. mSentFirstFrameLoadedEvent is true in BufferingState. 2. mMinimizePreroll is false in BufferingState for buffering happens after playback starts and we reset mMinimizePreroll once playback starts. MozReview-Commit-ID: ABE7TvNEetD
dom/media/MediaDecoderStateMachine.cpp
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -2215,23 +2215,21 @@ NextFrameSeekingState::HandleVideoNotDec
 }
 
 void
 MediaDecoderStateMachine::
 BufferingState::DispatchDecodeTasksIfNeeded()
 {
   const bool needToDecodeAudio =
     mMaster->IsAudioDecoding() &&
-    ((!mMaster->mSentFirstFrameLoadedEvent && AudioQueue().GetSize() == 0) ||
-     (!mMaster->mMinimizePreroll && !mMaster->HaveEnoughDecodedAudio()));
+   !mMaster->HaveEnoughDecodedAudio();
 
   const bool needToDecodeVideo =
     mMaster->IsVideoDecoding() &&
-    ((!mMaster->mSentFirstFrameLoadedEvent && VideoQueue().GetSize() == 0) ||
-     (!mMaster->mMinimizePreroll && !mMaster->HaveEnoughDecodedVideo()));
+    !mMaster->HaveEnoughDecodedVideo();
 
   if (needToDecodeAudio) {
     mMaster->EnsureAudioDecodeTaskQueued();
   }
 
   if (needToDecodeVideo) {
     mMaster->EnsureVideoDecodeTaskQueued();
   }