Bug 1315982 - findbugs: Ignore DE_MIGHT_IGNORE warning in FennecTabsRepositorySession.releaseProviders(). r?walkingice
MozReview-Commit-ID: 6jG2QDQ62l8
--- a/mobile/android/app/findbugs-exclude.xml
+++ b/mobile/android/app/findbugs-exclude.xml
@@ -1,19 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<FindBugsFilter>
- <!-- Bug 1315982 -->
- <Match>
- <Bug pattern="DE_MIGHT_IGNORE" />
- </Match>
-
<!-- Bug 1316008 -->
<Match>
<Bug pattern="DM_DEFAULT_ENCODING" />
</Match>
<!-- Bug 1320298 -->
<Match>
<Bug pattern="MS_MUTABLE_ARRAY" />
@@ -43,16 +38,23 @@
</Match>
<Match>
<Bug pattern="NP_NULL_ON_SOME_PATH" />
</Match>
<Match>
<Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
</Match>
+ <!-- We explicitly want to swallow exceptions in releaseProviders() (Bug 1315982) -->
+ <Match>
+ <Class name="org.mozilla.gecko.sync.repositories.android.FennecTabsRepository$FennecTabsRepositorySession" />
+ <Method name="releaseProviders" />
+ <Bug pattern="DE_MIGHT_IGNORE" />
+ </Match>
+
<!-- Ignore false positive in SerialRecordConsumer (Bug 1316011) -->
<Match>
<Class name="org.mozilla.gecko.sync.synchronizer.SerialRecordConsumer" />
<Method name="stored" />
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
</FindBugsFilter>