Bug 1328929 - enable no-unsafe-finally eslint rule for devtools; r?jryans draft
authorTom Tromey <tom@tromey.com>
Thu, 05 Jan 2017 10:32:47 -0700
changeset 456454 b0aee4825258da68b173f98eabb6706e0b05958c
parent 456410 221a84322295a392ef96005f85bc82e9eec2768e
child 541230 5678e92e996f6732760c140b61ce3508c562ad55
push id40500
push userbmo:ttromey@mozilla.com
push dateThu, 05 Jan 2017 17:33:52 +0000
reviewersjryans
bugs1328929
milestone53.0a1
Bug 1328929 - enable no-unsafe-finally eslint rule for devtools; r?jryans MozReview-Commit-ID: J8v5YELIyid
devtools/.eslintrc.js
--- a/devtools/.eslintrc.js
+++ b/devtools/.eslintrc.js
@@ -323,16 +323,18 @@ module.exports = {
     // Disallow the use of Boolean literals in conditional expressions.
     "no-unneeded-ternary": "error",
     // Disallow unreachable statements after a return, throw, continue, or break
     // statement.
     "no-unreachable": "error",
     // Disallow global and local variables that aren't used, but allow unused
     // function arguments.
     "no-unused-vars": ["error", {"vars": "all", "args": "none"}],
+    // Disallow flow control that escapes from "finally".
+    "no-unsafe-finally": "error",
     // Allow using variables before they are defined.
     "no-use-before-define": "off",
     // We use var-only-at-top-level instead of no-var as we allow top level
     // vars.
     "no-var": "off",
     // Allow using TODO/FIXME comments.
     "no-warning-comments": "off",
     // Disallow use of the with statement.