Bug 1328498 - Sourceeditor appendTo HTML element supports r?honza draft
authorRicky Chien <rchien@mozilla.com>
Wed, 04 Jan 2017 11:52:26 +0800
changeset 455537 d98df2618d6192fffad77a69cf37b7f90725c41a
parent 455536 57ac9f63fc6953f4efeb0cc84a60192d3721251f
child 541028 8235224ade35988f3a304db661f70437acc39d5b
push id40278
push userbmo:rchien@mozilla.com
push dateWed, 04 Jan 2017 03:54:11 +0000
reviewershonza
bugs1328498
milestone53.0a1
Bug 1328498 - Sourceeditor appendTo HTML element supports r?honza MozReview-Commit-ID: 1gdhH8PdIuc
devtools/client/sourceeditor/editor.js
--- a/devtools/client/sourceeditor/editor.js
+++ b/devtools/client/sourceeditor/editor.js
@@ -252,21 +252,23 @@ Editor.prototype = {
    *
    * This method is asynchronous and returns a promise.
    */
   appendTo: function (el, env) {
     let def = promise.defer();
     let cm = editors.get(this);
 
     if (!env) {
-      env = el.ownerDocument.createElementNS(XUL_NS, "iframe");
+      env = el.ownerDocument.createElementNS(el.namespaceURI, "iframe");
+
+      if (el.namespaceURI === XUL_NS) {
+        env.flex = 1;
+      }
     }
 
-    env.flex = 1;
-
     if (cm) {
       throw new Error("You can append an editor only once.");
     }
 
     let onLoad = () => {
       let win = env.contentWindow.wrappedJSObject;
 
       if (!this.config.themeSwitching) {