MozReview: Remove legacy 'Finish Review...' setter. (
Bug 1328280) r?smacleod
MozReview-Commit-ID: 1tSsLpkg3E9
--- a/pylib/mozreview/mozreview/static/mozreview/js/review.js
+++ b/pylib/mozreview/mozreview/static/mozreview/js/review.js
@@ -6,37 +6,33 @@
// Disable all editable fields in the review
// request box.
$(".main .editable").inlineEditor("disable");
// And then re-enable just the ones for reviewers in
// the commits list.
$("#mozreview-child-requests .editable").inlineEditor("enable");
- // Change string of "Review" button to be a verb so people better
- // understand what clicking it does.
- $("#review-link").text("Finish Review...");
-
if (MozReview.isParent) {
$('#review_request_extra').prepend(MRParents.parentWarning);
}
var reviewRequest = RB.PageManager.getPage().reviewRequest;
RB.apiCall({
type: 'GET',
prefix: reviewRequest.get('sitePrefix'),
noActivityIndicator: true,
url: '/api/review-requests/'+reviewRequest.get('id')+'/reviews/' +
'?max-results=200',
success: function(data) {
_.forEach(data.reviews, function(item) {
var flag = item.extra_data['p2rb.review_flag'];
var flagDesc = '';
var reviewText = $('#review'+item.id+' .body');
- switch(flag){
+ switch (flag) {
case ' ':
flagDesc = 'Review flag cleared';
break;
case 'r-':
case 'r+':
case 'r?':
flagDesc = 'Review flag: '+flag;
break;
@@ -48,17 +44,17 @@
}
});
// Tooltips for landable and "r?" cells
$('#mozreview-child-requests .help-tooltip, #mozreview-child-requests tbody .status').each(function() {
var $element = $(this);
var text = $element.attr('title');
- if(!text) return;
+ if (!text) return;
$element.attr('title', '');
// Draw the tooltip title and text
var $tip = $('<div></div>').attr('class', 'review-tooltip').appendTo($element);
$('<div></div>').attr('class', 'review-tooltip-text').text(text).appendTo($tip);
});