Bug 1328273 - Log mozrunner.utils failure messages at the error level, r?jgraham draft
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Tue, 03 Jan 2017 09:51:26 -0500
changeset 455326 c874a7b931c528e93508177c92249283d408807d
parent 455291 232424f9511d61179912ccaf5b169fb45f05599a
child 540954 69940f323467fe7cc7388f802c73ed72a422992f
push id40199
push userahalberstadt@mozilla.com
push dateTue, 03 Jan 2017 14:52:16 +0000
reviewersjgraham
bugs1328273
milestone53.0a1
Bug 1328273 - Log mozrunner.utils failure messages at the error level, r?jgraham MozReview-Commit-ID: A6d9fkA194r
testing/mozbase/mozrunner/mozrunner/utils.py
--- a/testing/mozbase/mozrunner/mozrunner/utils.py
+++ b/testing/mozbase/mozrunner/mozrunner/utils.py
@@ -157,18 +157,18 @@ def test_environment(xrePath, env=None, 
         try:
             # Symbolizer support
             llvmsym = os.path.join(xrePath, "llvm-symbolizer")
             if os.path.isfile(llvmsym):
                 env["ASAN_SYMBOLIZER_PATH"] = llvmsym
                 log.info("INFO | runtests.py | ASan using symbolizer at %s"
                          % llvmsym)
             else:
-                log.info("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find"
-                         " ASan symbolizer at %s" % llvmsym)
+                log.error("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find"
+                          " ASan symbolizer at %s" % llvmsym)
 
             # Returns total system memory in kilobytes.
             # Works only on unix-like platforms where `free` is in the path.
             totalMemory = int(os.popen("free").readlines()[1].split()[1])
 
             # Only 4 GB RAM or less available? Use custom ASan options to reduce
             # the amount of resources required to do the tests. Standard options
             # will otherwise lead to OOM conditions on the current test slaves.
@@ -213,18 +213,18 @@ def test_environment(xrePath, env=None, 
     if tsan and mozinfo.isLinux:
         # Symbolizer support.
         llvmsym = os.path.join(xrePath, "llvm-symbolizer")
         if os.path.isfile(llvmsym):
             env["TSAN_OPTIONS"] = "external_symbolizer_path=%s" % llvmsym
             log.info("INFO | runtests.py | TSan using symbolizer at %s"
                      % llvmsym)
         else:
-            log.info("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find TSan"
-                     " symbolizer at %s" % llvmsym)
+            log.error("TEST-UNEXPECTED-FAIL | runtests.py | Failed to find TSan"
+                      " symbolizer at %s" % llvmsym)
 
     return env
 
 
 def get_stack_fixer_function(utilityPath, symbolsPath):
     """
     Return a stack fixing function, if possible, to use on output lines.