Bug 894245 part 1 - Align windows widget behavior with other widgets to return failure when the specified color is unknown. r=jimm draft
authorXidorn Quan <me@upsuper.org>
Fri, 30 Dec 2016 14:17:55 +1100
changeset 454956 6b6c7fb1a578d2a129e399c534a8b651f32075bd
parent 454955 c9a40e66e1e8fa1c9086a91a5de14ce0d3778bbd
child 454957 dbe0b7f1eb45a59ef4df67ba5f1d75da1892cb17
push id40096
push userxquan@mozilla.com
push dateFri, 30 Dec 2016 23:12:12 +0000
reviewersjimm
bugs894245
milestone53.0a1
Bug 894245 part 1 - Align windows widget behavior with other widgets to return failure when the specified color is unknown. r=jimm MozReview-Commit-ID: HZ0Fir06QU6
widget/windows/nsLookAndFeel.cpp
--- a/widget/windows/nsLookAndFeel.cpp
+++ b/widget/windows/nsLookAndFeel.cpp
@@ -297,17 +297,19 @@ nsLookAndFeel::NativeGetColor(ColorID aI
       break;
     case eColorID__moz_buttondefault:
       idx = COLOR_3DDKSHADOW;
       break;
     case eColorID__moz_nativehyperlinktext:
       idx = COLOR_HOTLIGHT;
       break;
     default:
+      NS_WARNING("Unknown color for nsLookAndFeel");
       idx = COLOR_WINDOW;
+      res = NS_ERROR_FAILURE;
       break;
     }
 
   DWORD color = ::GetSysColor(idx);
   aColor = COLOREF_2_NSRGB(color);
 
   return res;
 }