Bug 1325148 - Temporarily disable leakchecking in crashtests on linux, r?jmaher draft
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 21 Dec 2016 17:06:29 -0500
changeset 454184 a70de09e4121feeacae4a884aa265ed4a5f4b74a
parent 454183 7e419a4b565046050dd96b35f9ac910fd1f6eef4
child 454185 90eb74954951bdbc0d7c0ebff1cbd2aa166c09e4
child 454187 0167ffc43ec851051bb7cd0bea750a451865a22c
child 454214 e31cd670215562f386afed4fb340078fa0c996e2
push id39859
push userahalberstadt@mozilla.com
push dateWed, 28 Dec 2016 14:22:54 +0000
reviewersjmaher
bugs1325148, 1325215
milestone53.0a1
Bug 1325148 - Temporarily disable leakchecking in crashtests on linux, r?jmaher This is being disabled because of the leak in bug 1325215. It slipped in because leak checking in reftest was temporarily failing to turn the job orange. We are disabling leak checking so we can land the fix ASAP and prevent further bustage from slipping through in the mean time. Once bug 1325215 has been fixed, this should be backed out. MozReview-Commit-ID: 74VGhHvZtIG
layout/tools/reftest/runreftest.py
--- a/layout/tools/reftest/runreftest.py
+++ b/layout/tools/reftest/runreftest.py
@@ -364,17 +364,27 @@ class RefTest(object):
             ix = v.find("=")
             if ix <= 0:
                 print "Error: syntax error in --setenv=" + v
                 return None
             browserEnv[v[:ix]] = v[ix + 1:]
 
         # Enable leaks detection to its own log file.
         self.leakLogFile = os.path.join(profileDir, "runreftest_leaks.log")
-        browserEnv["XPCOM_MEM_BLOAT_LOG"] = self.leakLogFile
+
+        # Leak checking was broken in reftest unnoticed for a length of time. During
+        # this time, a leak slipped into the crashtest suite. The leak checking was
+        # fixed by bug 1325148, but it couldn't land until the regression in crashtest
+        # was also fixed or backed out. Rather than waiting and risking new regressions,
+        # temporarily disable leak checking in crashtest. Fix is tracked by bug 1325215.
+        if options.suite == 'crashtest' and mozinfo.info['os'] == 'linux':
+            self.log.warning('WARNING | leakcheck disabled due to bug 1325215')
+        else:
+            browserEnv["XPCOM_MEM_BLOAT_LOG"] = self.leakLogFile
+
         return browserEnv
 
     def killNamedOrphans(self, pname):
         """ Kill orphan processes matching the given command name """
         self.log.info("Checking for orphan %s processes..." % pname)
 
         def _psInfo(line):
             if pname in line: